Knuckle Cracker

Creeper World => Custom Map Discussion => Topic started by: SPIFFEN on March 05, 2010, 06:10:38 AM

Title: Implement already uploaded !
Post by: SPIFFEN on March 05, 2010, 06:10:38 AM
Is it possibel to get an warning when you try to uploade an map you already have uploaded ?

Then we dont have to try uploading the same map more than 1 time ,
because we forget what maps we have uploaded and are in the waiting list for some time .

But dont deny the map to be uploaded , it might have small changes that should replace the first map .
Title: Re: Implement already uploaded !
Post by: knucracker on March 05, 2010, 02:58:34 PM
Yes, I am doing this tonight/tomorrow.  There may also be a little queue so you can see that you map has been uploaded and is waiting on approval.
The 'multiple uploads of the same map' has caused me no small set of headaches, so I definitely want to eliminate this problem.  So starting very soon your upload will fail if the map is already in the system (as a published map, or in the pending queue).
Title: Re: Implement already uploaded !
Post by: knucracker on March 06, 2010, 02:23:57 PM
Duplicate upload prevention is in place now.  I have also implemented a view into the pending queue.  So on the upload maps page you can see what maps are awaiting review.  Lastly, I have a new map approval system in place, so everyone should start to see maps get approved faster I hope.
Title: Re: Implement already uploaded !
Post by: SPIFFEN on March 06, 2010, 05:38:24 PM
Very nice =)

But i got an email about 1 of my maps where : Duplicate map
But it's avalibel in the custom map page .

Wasnt it an duplicate anyway or did it pass thoruh by and error during making this new feture ?

And if possibel , it would be nice to get an link to the map you have duplicated .
Then its easyer to change the map so its accepted as an new map .

Link to the map im talking about :
http://knucklecracker.com/creeperworld/mapcomments.php?id=877&page=

I dont want it to be there if it shouldnt be there =P
Title: Re: Implement already uploaded !
Post by: knucracker on March 06, 2010, 06:38:03 PM
Your map was uploaded before I had the duplicate stuff in place... so it got through before the upload page could stop it.
During the review process it probably got kicked because it had the same name and looked the same (and possibly was the same).

From here on out, the any map that matches a map already uploaded will get rejected on the upload page so you will know it is a dup immediately.  I suppose I could enhance the error page to show you which map it is a duplicate of....
Title: Re: Implement already uploaded !
Post by: Karsten75 on March 06, 2010, 06:57:49 PM
Quote from: SPIFFEN on March 06, 2010, 05:38:24 PM
Very nice =)

But i got an email about 1 of my maps where : Duplicate map
But it's avalibel in the custom map page .

Wasnt it an duplicate anyway or did it pass thoruh by and error during making this new feture ?

And if possibel , it would be nice to get an link to the map you have duplicated .
Then its easyer to change the map so its accepted as an new map .

Link to the map im talking about :
http://knucklecracker.com/creeperworld/mapcomments.php?id=877&page=

I dont want it to be there if it shouldnt be there =P

I approved a map of yours and then there was an exact duplicate in the queue, so I rejected the 2nd one in the queue. The fact that you think it passed review is because one of the two got through.
Title: Re: Implement already uploaded !
Post by: SPIFFEN on March 06, 2010, 07:07:32 PM
Ok so i had dubbel uploded it as some of my others maps because i forgot that i already had done it =P

So this new featur looks as it will work very well now/soon . =)
Title: Re: Implement already uploaded !
Post by: SPIFFEN on March 06, 2010, 07:17:07 PM
Will earlier maps be checked too after some time ?

I think i might have 3 other maps that has been dubbel oploaded .

If so , and if possibel , try to combine them ,
so comments and scores stays on the map that stays in the custom map page .
Title: Re: Implement already uploaded !
Post by: jem on March 07, 2010, 09:35:46 AM
what if you post a map, and then discover a bug and want to re upload it?
Title: Re: Implement already uploaded !
Post by: knucracker on March 07, 2010, 10:27:50 AM
Call it version 2 (or v1.1, or update1, etc).  An altered map is essentially a new map.  If I allowed a map to be replaced it would wipe out all of the scores posted on the first version that was uploaded.
Title: Re: Implement already uploaded !
Post by: jem on March 07, 2010, 11:07:05 AM
i mean before version is uploaded you upload the second.

and 1 other thing: what if you upload a map that has the same name as a map from a other person (without knowing that map exist)?
Title: Re: Implement already uploaded !
Post by: knucracker on March 07, 2010, 02:52:37 PM
Map names aren't unique identifiers.  So anyone can name any map anything basically.  This has already happened several times.  The map itself is what is unique and what I check for when you upload.

Now, if you do two maps that are only slightly different and upload them both and give them the same name, the system will let them through.  This is because they would be different maps.  However, the community might come down negatively on this as it is confusing.

Note that you can tell if you have uploaded a map already on the map upload page because I show the pending queue now.