Knuckle Cracker

Particle Fleet => Feedback, Features, and Suggestions => Topic started by: knucracker on July 05, 2017, 02:42:56 PM

Title: Map rating on mission completion dialog
Post by: knucracker on July 05, 2017, 02:42:56 PM
I've pushed a 1.1.5 version to steam on the beta channel that has a map rating widget on the mission completion dialog (for exchange missions).  Give it a look and see if it is working for you.  I did the leanest implementation I could get away with.
Title: Re: Map rating on mission completion dialog
Post by: Sorrontis on July 05, 2017, 02:51:56 PM
I'll test when I get home  8)

Got home edit: She's a beauty!
Title: Re: Map rating on mission completion dialog
Post by: GoodMorning on July 06, 2017, 08:37:51 AM
No issues here.
Title: Re: Map rating on mission completion dialog
Post by: GoodMorning on July 11, 2017, 07:09:28 PM
Slight issue. I just reloaded a map I'm working on, and the HQ on the map dissociated from the slot. I can now have two. Also, an energy mine was destroyed for no apparent reason. I have no reason to think that this was the beta, except that this is the first time I have saved/reloaded while using it.

Side bug from before the beta, replicable with the same save
The save also exhibits odd behaviour with GetControlPanelButtonScreenCoords - the new menu on-screen should react equally to the ship build panel movements when the UI scale changes. Given that it moves approximately twice as far as it should in Y and not at all in X, I'm guessing there's something like this:

#Copy/Paste
<-ScreenPosY <-MultiplierY mul/add ->ScreenPosY
<-ScreenPosY <-MultiplierY mul/add ->ScreenPosY #Change this to X when Y is properly tested
[close]

Log, screenshots attached. Steam screenshot present because some of the objects were in ScreenMode. Map ran for a few frames to check script functionality, then reloaded for screenshot and log.

Edit: Bug persists when loading in non-beta version. The map was last saved with the beta version. I don't know if this is a bad save, or if there is a flaw in the beta save/load. The symptoms have not changed.

Edit: Also demonstrates bridge-layering graphical thing, although that's not really a bug. Image attached anyway.
Title: Re: Map rating on mission completion dialog
Post by: Nicant on July 11, 2017, 08:04:16 PM
Works fine here!
Title: Re: Map rating on mission completion dialog
Post by: knucracker on July 13, 2017, 10:39:49 AM
Quote from: GoodMorning on July 11, 2017, 07:09:28 PM
Slight issue. I just reloaded a map I'm working on...

There was a null pointer exception in the load due to the energy source not existing but the mine does. The mine was trying to update its range based on the source, but the source wasn't there. I've added a check to protect against this scenario and the mission will load now (in the next build I'll put onto steam beta later today). It looks like this might have just been bad timing in your save. I don't think it has anything to do with the beta, as I don't remember changing anything in this area.
Title: Re: Map rating on mission completion dialog
Post by: GoodMorning on July 13, 2017, 06:58:50 PM
Thanks.